On Tue, 26 Jan 2021 23:25:03 GMT, Florent Guillaume 
<github.com+592810+e...@openjdk.org> wrote:

>> Mahendra Chhipa has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Implemented the review comments.
>
> test/jdk/java/lang/Class/forName/NonJavaNames.java line 67:
> 
>> 65:     @BeforeClass
>> 66:     public void createInvalidNameClasses() throws IOException {
>> 67:         Path hyphenPath = Paths.get(TEST_SRC + "hyphen.class");
> 
> Building a `Path` with string concatenation is an anti-pattern.
> Also `Path.of` is probably preferred instead of `Paths.get`.

Now not doing the concatenation of the strings to create Path.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2170

Reply via email to