On Tue, 9 Mar 2021 16:10:11 GMT, Sean Mullan <mul...@openjdk.org> wrote:

>> Bradford Wetmore has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Codereview Comment
>
> src/java.base/share/classes/javax/crypto/SealedObject.java line 428:
> 
>> 426:      * @throws IOException if an I/O error occurs
>> 427:      * @throws ClassNotFoundException if a serialized class cannot be 
>> loaded
>> 428:      * @throws NullPointerException if s is null.
> 
> Remove period for consistency with other throws. Actually, you probably don't 
> need to say that it throws NPE. I don't see that any other readObject method 
> declares that, even if they do throw NPE if the stream is null. Seems like 
> something that should just be assumed or does not happen under normal 
> circumstances.

It did seem really strange to me.  I'll remove.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2856

Reply via email to