On Wed, 10 Mar 2021 19:02:40 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More Codereview Comments
>
> src/java.base/share/classes/java/security/PrivilegedActionException.java line
> 101:
>
>> 99: * Serializable fields for UndeclaredThrowableException.
>> 100: *
>> 101: * @serialField exception Exception the undeclaredThrowable
>
> The "undeclaredThrowable" is confusing and not defined anywhere in this class
> specification. Suggest changing this to:
>
> The exception thrown by the privileged computation that resulted in this
> {@code PrivilegedActionException}.
Sure, good idea. Thanks.
> src/java.security.jgss/share/classes/javax/security/auth/kerberos/KeyImpl.java
> line 183:
>
>> 181: * @serialData this {@code KeyImpl} is serialized by
>> 182: * writing out the ASN1 Encoded bytes of the encryption key.
>> 183: * The ASN1 encoding is defined in RFC4120 and as follows:
>
> Nit: s/ASN1/ASN.1 (also on line 182).
Corrected.
> src/java.security.jgss/share/classes/javax/security/auth/kerberos/KeyImpl.java
> line 183:
>
>> 181: * @serialData this {@code KeyImpl} is serialized by
>> 182: * writing out the ASN1 Encoded bytes of the encryption key.
>> 183: * The ASN1 encoding is defined in RFC4120 and as follows:
>
> Remove "and" and extra space after "as"
Done.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2856
