On Wed, 14 Apr 2021 11:17:14 GMT, Erik Gahlin <egah...@openjdk.org> wrote:
>> Jaroslav Bachorik has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >> commits since the last revision: >> >> - Roll back conditional registration of container events >> - Remove container events flag >> - Remove trailing spaces >> - Doh >> - Report container type and register events conditionally >> - Remove unused test files >> - Initial test support for JFR container events >> - Update the JFR control files >> - Split off the CPU throttling metrics >> - Formatting spaces >> - ... and 1 more: >> https://git.openjdk.java.net/jdk/compare/b72abe91...67a61bd7 > > src/jdk.jfr/share/classes/jdk/jfr/events/ContainerMemoryUsageEvent.java line > 46: > >> 44: public final class ContainerMemoryUsageEvent extends AbstractJDKEvent { >> 45: @Label("Memory Pressure") >> 46: @Description("(attempts per second * 1000), if enabled, that the >> operating system tries to satisfy a memory request for any " + > > This unit seems a bit strange. Do we really need to multiply by 1000? This is taken as reported by cgroups - I didn't want to change the semantics so it does not confuse people familiar with cgroups. ------------- PR: https://git.openjdk.java.net/jdk/pull/3126
