On Sat, 29 Jan 2022 16:13:46 GMT, Yasser Bazzi <d...@openjdk.java.net> wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default method `asRandom()` that wraps around the >> newer algorithms to be used on classes that do not accept the new interface. >> >> Some things to note as proposed by the bug report, the protected method >> next(int bits) is not overrided and setSeed() method if left blank up to >> discussion on what to do with it. >> >> Small test done on >> https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4 > > Yasser Bazzi has updated the pull request incrementally with two additional > commits since the last revision: > > - fix missing periods > - Use final on initialized variable I agree with Stuart. This should be added to Random not RandomGenerator. That leaves room in the distant future to deprecate Random without leaving dangly bits on the interface. This also makes sense from an API perspective. RandomGenerator shouldn't force an unnecessary burden on an implementation even as a default. ------------- PR: https://git.openjdk.java.net/jdk/pull/7001
