On Sat, 29 Jan 2022 16:10:28 GMT, Yasser Bazzi <d...@openjdk.java.net> wrote:
> Oh sorry about that, my IDE probably did the changes and it went unnoticed by > me, should i revert the offending commit and recommit only the appropriate > changes? Just add a new commit that undoes the unwanted changes. Please don't rebase and force-push (if you were thinking of doing that) because it disrupts the historical comments and incremental diffs. Note that when this is eventually integrated, all the intermediate commits will be "squashed" and a single consolidated commit will be pushed into the JDK mainline. By the way, I'm still thinking about the API factoring issue, and I'm leaning toward having a static factory method on Random instead of a default on RandomGenerator. Still open for discussion though. ------------- PR: https://git.openjdk.java.net/jdk/pull/7001
