On Sat, 16 Apr 2022 09:25:20 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Refresh
>> - Refresh
>> - Merge with jdk-19+18
>> - Refresh
>> - Initial push
>
> src/java.base/share/classes/java/io/BufferedOutputStream.java line 136:
>
>> 134: * are added. A no-op if the buffer is not resizable.
>> 135: */
>> 136: private void growIfNeeded(int len) {
>
> Hello Alan, like some methods in other classes (BufferedInputStream#fill()
> for example), should we mention here that this method assumes that it's being
> called while a lock is held?
Okay, we can add a comment to these methods (asserts are possible but tend not
to be used in this area).
-------------
PR: https://git.openjdk.java.net/jdk/pull/8166
