On Mon, 9 May 2022 09:25:15 GMT, Raffaello Giulietti <d...@openjdk.java.net> wrote:
>> Please review these small changes to address intermittent failures, as of >> JDK-8274517. >> >> - Usage of jdk.test.lib.RandomFactory for reproducible random generation. >> - Slightly less restrictive assertion about badParallelStreamError on L94 >> (former L88). >> - Verbatim copy of computeFinalSum() from j.u.s.Collectors 18. >> >> While these changes do not necessarily guarantee absence of intermittent >> failures, the usage of jdk.test.lib.RandomFactory should at least help to >> pin down specific double sequences that do not pass the test. >> >> There is still an inherent variability due to the use of parallel streams, >> though. As double addition is not perfectly associative, even a fully known >> sequence of doubles may lead to slightly different results with >> parallelization. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with > expected [true] but found [false] > > Merge branch 'master' into JDK-8274517 > - 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with > expected [true] but found [false] Post Loom merge ------------- PR: https://git.openjdk.java.net/jdk/pull/8290
