On Tue, 19 Apr 2022 08:40:51 GMT, Raffaello Giulietti <d...@openjdk.java.net> wrote:
> Please review these small changes to address intermittent failures, as of > JDK-8274517. > > - Usage of jdk.test.lib.RandomFactory for reproducible random generation. > - Slightly less restrictive assertion about badParallelStreamError on L94 > (former L88). > - Verbatim copy of computeFinalSum() from j.u.s.Collectors 18. > > While these changes do not necessarily guarantee absence of intermittent > failures, the usage of jdk.test.lib.RandomFactory should at least help to pin > down specific double sequences that do not pass the test. > > There is still an inherent variability due to the use of parallel streams, > though. As double addition is not perfectly associative, even a fully known > sequence of doubles may lead to slightly different results with > parallelization. This pull request has now been integrated. Changeset: 97a98352 Author: Raffaello Giulietti <raffaello.giulie...@oracle.com> Committer: Alan Bateman <al...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/97a983526b41d26fcd1caa162a089690119874b0 Stats: 13 lines in 1 file changed: 7 ins; 0 del; 6 mod 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false] Reviewed-by: alanb, bpb ------------- PR: https://git.openjdk.java.net/jdk/pull/8290