> Can I please get a review of this change which proposes to fix the failure > handler command `dmesg` on macOS? > > As noted in the JBS issue, the command currently fails with permission error. > The commit in this PR uses `sudo` as suggested in the man pages of that > command. > > Tested locally on macOS by running: > > > cd test/failure_handler > make clean > make test > > Then checked the generated environment.html files for the dmesg command > output. Looks fine after this change.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision: copyright year ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/8703/files - new: https://git.openjdk.java.net/jdk/pull/8703/files/db538083..f85acab5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8703&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8703&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/8703.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8703/head:pull/8703 PR: https://git.openjdk.java.net/jdk/pull/8703
