On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

>> Can I please get a review of this change which proposes to fix the failure 
>> handler command `dmesg` on macOS?
>> As noted in the JBS issue, the command currently fails with permission 
>> error. The commit in this PR uses `sudo` as suggested in the man pages of 
>> that command.
>> Tested locally on macOS by running:
>> cd test/failure_handler
>> make clean
>> make test
>> Then checked the generated environment.html files for the dmesg command 
>> output. Looks fine after this change.
> Jaikiran Pai has updated the pull request incrementally with one additional 
> commit since the last revision:
>   copyright year

Thank you Daniel and Lance for the reviews. 

Would anyone from the build team provide any additional reviews?


PR: https://git.openjdk.java.net/jdk/pull/8703

Reply via email to