On Fri, 13 May 2022 14:17:44 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

> Can I please get a review of this change which proposes to fix the failure 
> handler command `dmesg` on macOS?
> As noted in the JBS issue, the command currently fails with permission error. 
> The commit in this PR uses `sudo` as suggested in the man pages of that 
> command.
> Tested locally on macOS by running:
> cd test/failure_handler
> make clean
> make test
> Then checked the generated environment.html files for the dmesg command 
> output. Looks fine after this change.

This pull request has now been integrated.

Changeset: 125efe6c
Author:    Jaikiran Pai <j...@openjdk.org>
Stats:     4 lines in 1 file changed: 2 ins; 0 del; 2 mod

8286744: failure_handler: dmesg command on macos fails to collect data due to 
permission issues

Reviewed-by: dfuchs, lancea, lmesnik


PR: https://git.openjdk.java.net/jdk/pull/8703

Reply via email to