On Wed, 18 May 2022 06:12:41 GMT, David Holmes <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - Use assert() to check jargv
>> - Merge remote-tracking branch 'upstream/master' into JDK-8286694
>> - 8286694: Incorrect argument processing in java launcher
>
> src/java.base/share/native/libjli/java.c line 1631:
>
>> 1629: const char *arg = jargv[i];
>> 1630: if (arg[0] == '-' && arg[1] == 'J') {
>> 1631: assert(arg[2] != '\0' && "Invalid JAVA_ARGS or
>> EXTRA_JAVA_ARGS defined by build");
>
> Interesting trick.
Since we pass NDEBUG, this assert is disabled in release builds. This is the
supposed behavior, right? That we don't do anything on release builds?
-------------
PR: https://git.openjdk.java.net/jdk/pull/8694
