> This change is a follow-up to [this 
> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
> 
> Override implementation is based on [this 
> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14510886&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14510886).
> 
> As suggested in [this 
> comment](https://github.com/openjdk/jdk/pull/9753#pullrequestreview-1062560789)
>  only English translation is provided for new `resource.wxl-file` label.
> 
> `getTempdirectory` utility was moved from `BasicTest` to `WindowsHelper` to 
> be able to provide `--temp` and inspect the contents of `config` dir in 
> verifier. It is not clear if `WindowsHelper` is an appropriate place for this 
> utility (`BasicTest` is not Windows-specific), I've assumed that `--temp` 
> flag itself is only used on Windows.
> 
> Testing:
> 
>  - [x] enhanced `WinL10nTest` adding checks for `-loc` arguments to 
> `light.exe` and additional `@Parameter` run that overrides one of the primary 
> `.wxl` files
>  - [x] ran jtreg:jdk/tools/jpackage/windows and a `BasicTest` in unpack mode

Alex Kasko has updated the pull request incrementally with one additional 
commit since the last revision:

  add english entries to all l10n files

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9780/files
  - new: https://git.openjdk.org/jdk/pull/9780/files/d4ba8bf0..097ae46e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9780&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9780&range=00-01

  Stats: 3 lines in 3 files changed: 3 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/9780.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9780/head:pull/9780

PR: https://git.openjdk.org/jdk/pull/9780

Reply via email to