On Wed, 10 Aug 2022 13:12:57 GMT, Alex Kasko <aka...@openjdk.org> wrote:
>> This change is a follow-up to [this >> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038). >> >> Override implementation is based on [this >> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14510886&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14510886). >> >> As suggested in [this >> comment](https://github.com/openjdk/jdk/pull/9753#pullrequestreview-1062560789) >> only English translation is provided for new `resource.wxl-file` label. >> >> `getTempdirectory` utility was moved from `BasicTest` to `WindowsHelper` to >> be able to provide `--temp` and inspect the contents of `config` dir in >> verifier. It is not clear if `WindowsHelper` is an appropriate place for >> this utility (`BasicTest` is not Windows-specific), I've assumed that >> `--temp` flag itself is only used on Windows. >> >> Testing: >> >> - [x] enhanced `WinL10nTest` adding checks for `-loc` arguments to >> `light.exe` and additional `@Parameter` run that overrides one of the >> primary `.wxl` files >> - [x] ran jtreg:jdk/tools/jpackage/windows and a `BasicTest` in unpack mode > > Alex Kasko has updated the pull request incrementally with one additional > commit since the last revision: > > fixes for bundling with different cultures I don't think it is good that the encoding of jpackage output depends on the default jvm encoding. It is convenient to know that the output is always in a specific encoding regardless of the values of `user.language` and `user.country` system properties. But this might not be the case of help and error output produced by jpackage. Let's keep jpackage aligned with other JDK tools. Could you please check the behavior of `java`? How the output of `java --help` is encoded? ------------- PR: https://git.openjdk.org/jdk/pull/9780
