On Tue, 20 Sep 2022 04:05:56 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
>> Problem is that [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850) >> never set correct value in .jpackage.xml to mark image as signed. >> [JDK-8289030](https://bugs.openjdk.org/browse/JDK-8289030) reads this value >> to check if we can add per-user and system wide configuration to packaged >> app. Fixed by setting correct value in .jpackage.xml when we signing >> predefine application image. >> >> Added tests to cover this case and added check for values inside >> .jpackage.xml to validate signed and Mac App Store values. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8293462: [macos] app image signature invalid when creating DMG or PKG from > post processed signed image [v2] src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppImageBuilder.java line 286: > 284: if (appImageFile != null) { > 285: appImageFile.save(predefinedAppImage); > 286: } Wouldn't it make sense to rethrow caught exception after the file is restored? ------------- PR: https://git.openjdk.org/jdk/pull/10316
