On Fri, 23 Sep 2022 20:40:29 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293462: [macos] app image signature invalid when creating DMG or PKG from
>> post processed signed image [v2]
>
> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppImageBuilder.java
> line 286:
>
>> 284: if (appImageFile != null) {
>> 285: appImageFile.save(predefinedAppImage);
>> 286: }
>
> Wouldn't it make sense to rethrow caught exception after the file is restored?
Fixed.
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java line
> 64:
>
>> 62:
>> 63: // These values will be loaded from AppImage xml file.
>> 64: private final Path appImageDir;
>
> What this field is for? This property doesn't belong to the class.
It was used to show path to .jpackage.xml file in case of error from
copyAsSigned(), but it is actually not needed, since copyAsSigned() should not
produce invalid app image file.
-------------
PR: https://git.openjdk.org/jdk/pull/10316
