On Fri, 17 Feb 2023 13:50:17 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains three additional commits >> since the last revision: >> >> - Update regression test. >> - Merge branch 'master' into JDK-8302028 >> - JDK-8302028: Port fdlibm atan2 to Java > > src/java.base/share/classes/java/lang/FdLibm.java line 447: > >> 445: ly = __LO(y); >> 446: if (((ix | ((lx | -lx) >> 31)) > 0x7ff0_0000)|| >> 447: ((iy |((ly | - ly) >> 31)) > 0x7ff0_0000)) // x or y >> is NaN > > I think that `>> 31` must be replaced by `>>> 31`. Well spotted; corrected the code and added additional tests to catch that case. Thanks. ------------- PR: https://git.openjdk.org/jdk/pull/12608
