On Wed, 3 May 2023 13:42:03 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update based on @erikj79 review comments and suggestions: >> - Change to copy libjvm.a for $(JVM_VARIANT_MAIN) only in >> make/StaticLibsImage.gmk. >> - Use $(OBJ_SUFFIX) instead of .o in >> make/modules/java.base/lib/CoreLibraries.gmk. > > make/StaticLibsImage.gmk line 61: > >> 59: $(eval TARGETS += $$(COPY_STATIC_LIBS_libjvm)) \ >> 60: ) >> 61: > > Won't this fail if we were building more than one variant? Perhaps only put > `$(JVM_VARIANT_MAIN)` in the static image to avoid problems? Changed to copy for $(JVM_VARIANT_MAIN) only, as suggested. Thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13768#discussion_r1184061602
