On Mon, 12 Jun 2023 05:41:08 GMT, Oliver Kopp <d...@openjdk.org> wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>> line 754:
>>
>>> 752: // Restore all (!) sets from parameter to
>>> local variables
>>> 753: if (nextLocalVar > firstVariableForDedup) {
>>> 754: // We need to go from the end to the
>>> beginning as we will probably overwrite position 2 (which holds the list at
>>> the beginning)
>>
>> Do you mind fixing all the comments as these 160+ lines make it impossible
>> to look at the changes side-by-side again. You had fixed that in the
>> original PR but it looks like they have come back with this PR.
>
>> Do you mind fixing all the comments as these 160+ lines
>
> Done. I copied the (for me) important comments to the GitHub reply
> https://github.com/openjdk/jdk/pull/14408#issuecomment-1586615579.
>
>> You had fixed that in the original PR but it looks like they have come back
>> with this PR.
>
> This is my job training 😇: Comment the core ideas (and do not verbatim repeat
> what is said by the code directly). - For me, the good thing is, the diff now
> has all the comments
> (https://github.com/openjdk/jdk/pull/14408/commits/23bbc0ce0c8fd8a4cd689c0260c5fbcb91b20046).
> OK, at least one has go to nirvana in all cases.
Yes, the verify errors are gone. Application (JabRef) starts sucessfully
against the compilation. Is there a way to verify in a tesr the creation of the
helper methos in the bytecode? e.g. something like getDeclaredMethods?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14408#discussion_r1226170715
