On Mon, 12 Jun 2023 05:03:28 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Oliver Kopp has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'upstream/master' into fix-8240567 >> - Merge remote-tracking branch 'upstream/master' into fix-8240567 >> - Remove "final" at "enabled" - not part of the point of this PR >> - Remove comments >> - 8240567: MethodTooLargeException thrown while creating a jlink image >> >> Co-authored-by: Christoph Schwentker <siedlerkil...@gmail.com> > > @koppor Is this ready for review? The other PR went through a dozens or so > iterations before it was returned to draft. It seems like you were still > battling with verifier errors. The comment on this PR says you it was created > because a force-push so I can't tell if you the changes are ready or not. > @AlanBateman The diff to the "old" PR #10704 is as follows. Maybe this helps > at reviewing? IMHO this diff shows very good the new passing of the locals > required by the deduplication functionality. It's good that you've got to a patch that doesn't trip the verifier. It is one my list to look at the latest version. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14408#issuecomment-1594528830
