On Thu, 15 Jun 2023 06:32:06 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 183:
>> 
>>> 181:             case "locale":
>>> 182:                 printLocale();
>>> 183:                 break;
>> 
>> printLocale might need the same treatment to avoid printing the list of all 
>> locales by default.
>
> Have you tried putting the new code into say sun.launcher.SecuritySettings to 
> avoid adding so much security conf code into LauncherHelper? Maybe eventually 
> this will need to a more pluggable as -XshowSettings has grown a bit beyond 
> what it was originally for.

Logged https://bugs.openjdk.org/browse/JDK-8310201 to track the Locale changes 
Alan.

Good suggestion on factoring out the security code to a helper class. Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1232109645

Reply via email to