On Fri, 23 Jun 2023 20:00:12 GMT, Glavo <d...@openjdk.org> wrote: > Using `ByteArrayLittleEndian` is simpler and faster. > > `make test TEST="micro:java.util.zip.ZipFileOpen"`: > > > Benchmark (size) Mode Cnt Score Error Units > - ZipFileOpen.openCloseZipFile 512 avgt 15 39052.832 ± 107.496 ns/op > + ZipFileOpen.openCloseZipFile 512 avgt 15 36275.539 ± 663.193 ns/op > - ZipFileOpen.openCloseZipFile 1024 avgt 15 77106.494 ± 4159.300 ns/op > + ZipFileOpen.openCloseZipFile 1024 avgt 15 71955.013 ± 2296.050 ns/op
Looks great. Created https://bugs.openjdk.org/browse/JDK-8310837 for your patch. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14632#issuecomment-1605200217
