On Mon, 21 Aug 2023 07:14:44 GMT, Vladimir Petko <vpe...@openjdk.org> wrote:
>> 8314491: Linux: jexec launched via PATH fails to find java > > Vladimir Petko has updated the pull request incrementally with one additional > commit since the last revision: > > Review comment: use /proc/self/exe as the backup option Thanks for the update, I feel much more comfortable with this change now. Please wait for a second review however. Thanks src/java.base/unix/native/launcher/jexec.c line 162: > 160: int argi = 0; /* index into old array */ > 161: size_t alen = 0; /* length of new array */ > 162: int error = 0; /* getJavaPath error */ Nit: no need to pre-declare this, just use `int error = getJavaPath(...)` ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15343#pullrequestreview-1586415445 PR Review Comment: https://git.openjdk.org/jdk/pull/15343#discussion_r1299744492
