On Mon, 21 Aug 2023 21:36:13 GMT, David Holmes <dhol...@openjdk.org> wrote:
>>> Nit: no need to pre-declare this, just use `int error = getJavaPath(...)` >> >> This one was intentional to keep the style consistent =) > > The others are more widely used and there is a desire to document their > meaning. That isn't necessary for this case, but as I said, just a nit. Updated and re-run Jexec test. ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/tools/launcher/Jexec.java 1 1 0 0 ============================== TEST SUCCESS ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15343#discussion_r1300725435
