On Tue, 10 Oct 2023 12:46:22 GMT, Sean Coffey <coff...@openjdk.org> wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > incorporate review comments Thanks for the comments to date. I think the latest commit should satisfy requests made. for `Key.equals(Object)` and `Key.hashCode()` - I've changed the impl so that attrs.lastModifiedTime() is only used in the case where `attrs.fileKey()` returns null. Is that in the direction you were suggesting Alan ? ------------- PR Comment: https://git.openjdk.org/jdk/pull/16115#issuecomment-1755350508
