On Fri, 13 Oct 2023 08:45:07 GMT, Sean Coffey <coff...@openjdk.org> wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > insert back lastmodified check. enhance testcase. more review comments `lastModifiedTime()` was used in the native code and brought across when native code was removed in JDK-8145260 I thought we might be able to drop it for the case where we have a unique file key but that won't cover the case where an existing zip file is opened and modified. Re-introduced the lastModifiedTime checks as a result. We need to be able to detect such scenarios, otherwise new ZipFile constructs would continue to use a stale <Key, Source> mapping (if such Keys still existed) I've updated the test case to junit format and beefed it up with some extra scenarios to cover the above. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16115#issuecomment-1761146357
