On Tue, 7 Nov 2023 18:34:42 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to
>> mechanically convert a classfile for a Class into an in-memory class
>> representation of an equivalent Interface. `testPrivateMethodCall` tests
>> to invoke a private method. Before nestmates, invoking a private class
>> method and a private interface method both use `Invokespecial`. With the
>> nestmate changes, the class uses `invokevirtual` but the interface must use
>> `invokeinterface` but this conversion is not handled by the existing
>> `ClassToInterfaceConverter`.
>>
>> This fix converts `ClassToInterfaceConverter` to use the Class-File API to
>> properly convert a classfile from a class to an interface including method
>> invocation from `invokevirtual` to `invokeinterface`. The old custom
>> bytecode manipulation code can be dropped.
>
> Mandy Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Simplify the transformation code and easier to read
test/jdk/jdk/lambda/separate/ClassToInterfaceConverter.java line 53:
> 51:
> 52: return Classfile.of().transform(classModel,
> 53: ClassTransform.dropping(ce -> ce instanceof MethodModel mm &&
> mm.methodName().stringValue().equals("<init>"))
`Utf8Entry::equalsString(…)` might be more efficient:
Suggestion:
ClassTransform.dropping(ce -> ce instanceof MethodModel mm &&
mm.methodName().equalsString("<init>"))
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16526#discussion_r1385431990
