On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461) src/java.base/share/classes/java/util/stream/Gatherer.java line 444: > 442: */ > 443: static <T, A, R> Gatherer<T, A, R> of( > 444: Supplier<A> initializer, wildcards are missing here too, Supplier<? extends A>, Integrator<? super A, ? super T, ? extends R> and BiConsumer<? super A, ? super Downstream<? super R>>. src/java.base/share/classes/java/util/stream/Gatherer.java line 490: > 488: * more elements sent to it, {@code false} if otherwise > 489: */ > 490: default boolean isRejecting() { return false; } Is it really a good default ? src/java.base/share/classes/java/util/stream/Gatherer.java line 530: > 528: * @param <R> the type of results this integrator can produce > 529: */ > 530: @ForceInline If we add this kind of the methods, we should add them on all function interfaces of java.util.function and java.util.stream. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1386965623 PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1386966965 PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1386970112
