On Wed, 8 Nov 2023 17:26:35 GMT, Rémi Forax <fo...@openjdk.org> wrote:
>> src/java.base/share/classes/java/util/stream/Gatherer.java line 490:
>>
>>> 488: * more elements sent to it, {@code false} if otherwise
>>> 489: */
>>> 490: default boolean isRejecting() { return false; }
>>
>> Is it really a good default ?
>
> It is not better to have 2 Downstream (Downstream and a subtype) like you hae
> two integrators (Integrator and Greedy)
Yes, it's the best possible default.
The Downstream can become rejecting after any push, so any operations which do
multiple pushes would not see that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1386996877
