On Thu, 23 Nov 2023 14:10:02 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments in build system
>
> make/autoconf/lib-vmath.m4 line 89:
>
>> 87: if test "x${LIBSLEEF_FOUND}" = "xyes"; then
>> 88: ENABLE_LIBSLEEF=true
>> 89: LIBVMATH_LIBS="${LIBVMATH_LIBS} -lsleef"
>
> Remove this line. It would just add `-lsleef` twice if you go via
> `PKG_CHECK_MODULES`. You need to set -lsleef at the correct places.
Correct. Thanks! I will adjust all the relative names/cflags once the sve
cflags is removed in the m4 file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16234#discussion_r1405526805
