On Tue, 21 Nov 2023 09:13:59 GMT, Viktor Klang <vkl...@openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/ref/Reference.java line 505:
>> 
>>> 503:      * to return this reference even though the referent is still 
>>> strongly
>>> 504:      * reachable. That is, before the referent has reached the expected
>>> 505:      * reachability level.
>> 
>> The wording here is kind of awkward. We could try to wordsmith it, but there 
>> is also the possibility that there are valid use cases for using enqueue(), 
>> which makes this caution seem misplaced. An alternative would simply be to 
>> omit this paragraph.
>
> Might be better to leave out the last sencence?

I'll take out the last sentence, and we can continue discussing whether to keep 
this note at all.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16644#discussion_r1411305306

Reply via email to