On Thu, 21 Dec 2023 12:49:02 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy >> classes. >> >> This patch converts it to use Classfile API. >> >> It is continuation of https://github.com/openjdk/jdk/pull/10991 >> >> Any comments and suggestions are welcome. >> >> Please review. >> >> Thank you, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last revision: > > applied the recommended changes src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java line 62: > 60: private final Utf8Entry methodDesc; > 61: private final SplitConstantPool cp; > 62: private final ArrayDeque<Target> targets; This field can probably be typed as a `Deque`: Suggestion: private final Deque<Target> targets; Or as a `Queue`: Suggestion: private final Queue<Target> targets; ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17121#discussion_r1435349464
