On Mon, 8 Jan 2024 13:38:16 GMT, Adam Sotona <asot...@openjdk.org> wrote:
> ClassFile API performance related improvements have been separated from
> #17121 into this PR.
>
> These improvements are important to minimize performance regression of
> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the
> Classfile API to generate proxy classes #17121
>
> Please review.
>
> Thanks,
> Adam
src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java line
338:
> 336: }
> 337:
> 338: private static int countMethodStack(Utf8Entry descriptor, boolean
> subReturn) {
Since we use this for both locals and stack, perhaps "countMethodSlots" would
be better? And maybe the "subReturn" could be a flag to switch between
locals/stack
src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java line
417:
> 415: bcs.bci,
> 416: methodName,
> 417:
> MethodTypeDesc.ofDescriptor(methodDesc.stringValue()).displayDescriptor()));
This seems unrelated?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17306#discussion_r1444719273
PR Review Comment: https://git.openjdk.org/jdk/pull/17306#discussion_r1444721284
