On Mon, 8 Jan 2024 14:19:12 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> applied suggested changes > > src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java > line 338: > >> 336: } >> 337: >> 338: private static int countMethodStack(Utf8Entry descriptor, boolean >> subReturn) { > > Since we use this for both locals and stack, perhaps "countMethodSlots" would > be better? And maybe the "subReturn" could be a flag to switch between > locals/stack I've changes the name to the suggested "countMethodSlots" and "subReturn" to "asStackDelta" , thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17306#discussion_r1444934827