On Sat, 24 Feb 2024 18:54:07 GMT, Lance Andersen <[email protected]> wrote:
>> Please review this PR which addresses the handling of invalid UTF-8 byte
>> sequences in the entry name of a LOC file header and a Zip file comment
>> which is returned via ZipFile::getComment.
>>
>> As part of the change, `ZipFile::getComment` will now return `null` if an
>> invalid UTF-8 byte sequence is encountered while converting the byte array
>> to a String. The CSR for this change has also been approved.
>>
>> Mach5 tiers 1-3 are clean with this change.
>
> Lance Andersen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updates based on 1st round of feedback
src/java.base/share/classes/java/util/zip/ZipInputStream.java line 524:
> 522: : zc.toString(b, len);
> 523: } catch(Exception ex) {
> 524: throw (ZipException) new ZipException(
Whitespace nit:
Suggestion:
} catch (Exception ex) {
throw (ZipException) new ZipException(
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17995#discussion_r1501809393
