On Sun, 25 Feb 2024 12:16:14 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Hello Lance, the changes look fine to me. `ZipFile.java` file will need a
> copyright year update.
Thank you Jai, updated
> test/jdk/java/util/zip/ZipFile/InvalidBytesInEntryNameOrComment.java line 189:
>
>> 187: try (ZipFile zf = new ZipFile(ZIP_FILE.toFile())) {
>> 188: var comment = zf.getComment();
>> 189: System.out.printf("Comment= %s%n", comment);
>
> Should we assert for the valid expected `comment` here?
Sure I can add the validation
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17995#issuecomment-1962954345
PR Review Comment: https://git.openjdk.org/jdk/pull/17995#discussion_r1501822988
