On Mon, 2 Sep 2024 16:02:31 GMT, Andrew John Hughes <and...@openjdk.org> wrote:
>> fitzsim has updated the pull request incrementally with one additional >> commit since the last revision: >> >> BootClassPathZipFileTest: Switch to createClassBytes, createZip static >> functions > > I can't review, as I ported the native code changes. On that note, can you > make sure I'm credited as co-author using > [/contributor](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/contributor) > please? > > i.e. /contributor add @gnu-andrew > > You may want to also comment on > [JDK-8185896](https://bugs.openjdk.org/browse/JDK-8185896) which is about > adding Zip64 tests. > Hi @gnu-andrew, I have corrected your contributor status, thank you for the > reminder. > > I do not have access to comment on > https://bugs.openjdk.org/browse/JDK-8185896. Can you please add a comment > from me that says: > > "I have added to #19678 two ZIP64 test cases: one for ZIP64 extensions added > implicitly due to one of the CEN fields being too large to represent, and one > for ZIP64 extensions that have been added explicitly even though no CEN field > required them. > > It is not complete coverage -- the "implicit" test only tests the field for > the total number of entries. But the coverage they provide may be enough to > warrant closing JDK-8185896. > > The test cases are fast and portable back to OpenJDK 8, and do not require > significant disk space, so they can be run unconditionally as part of the > default `jtreg` test set." Done. Thanks for adding the attribution. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19678#issuecomment-2327687252
