On Wed, 4 Sep 2024 11:33:39 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> fitzsim has updated the pull request incrementally with one additional >> commit since the last revision: >> >> BootClassPathZipFileTest: Switch to createClassBytes, createZip static >> functions > > test/hotspot/jtreg/runtime/BootClassAppendProp/BootClassPathZipFileCreator.java > line 1: > >> 1: /* > > Shouldn't this be in `test/jdk/java/util/zip`? OK. I was not sure the best place for them, because they test the handling of Zip files on the `HotSpot` bootstrap class path. But the creator class could be reused for other Zip tests, so `test/jdk/java/util/zip` is probably better. I will move both the creator and the test files to `test/jdk/java/util/zip`. The creator class could/should maybe be named more generically, but as a first step I will just move the files. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19678#discussion_r1743944490
