On Wed, 31 Jul 2024 21:54:15 GMT, fitzsim <d...@openjdk.org> wrote:
>> 8334048: -Xbootclasspath can not read some ZIP64 zip files
>
> fitzsim has updated the pull request incrementally with one additional commit
> since the last revision:
>
> BootClassPathZipFileTest: Switch to createClassBytes, createZip static
> functions
Not an expert in this area, so just a drive-by review.
test/hotspot/jtreg/runtime/BootClassAppendProp/BootClassPathZipFileCreator.java
line 1:
> 1: /*
Shouldn't this be in `test/jdk/java/util/zip`?
test/hotspot/jtreg/runtime/BootClassAppendProp/BootClassPathZipFileCreator.java
line 76:
> 74: env.put("forceZIP64End", "true");
> 75: }
> 76: Path zip = Paths.get(System.getProperty("user.dir"), type +
> ".zip");
Should we use `test.classes` (i.e. `System.getProperty("test.classes",
System.getProperty("user.dir")`) dir for those transient files?
test/hotspot/jtreg/runtime/BootClassAppendProp/BootClassPathZipFileTest.java
line 49:
> 47: // the ZIP file not existing is the same as the ZIP file not being
> 48: // readable, that is, ClassNotFoundException on CLASS_NAME.
> 49: Path zipPath = Paths.get(System.getProperty("user.dir"), args[0]);
`test.classes` here as well.
-------------
PR Review: https://git.openjdk.org/jdk/pull/19678#pullrequestreview-2279860073
PR Review Comment: https://git.openjdk.org/jdk/pull/19678#discussion_r1743599742
PR Review Comment: https://git.openjdk.org/jdk/pull/19678#discussion_r1743616270
PR Review Comment: https://git.openjdk.org/jdk/pull/19678#discussion_r1743616812
