On Fri, 25 Oct 2024 01:38:55 GMT, Henry Jen <henry...@openjdk.org> wrote:
> Check output for including values rather than exact match. > Also include the manpage change and revert the problem list. I am not sure how others feel, but I think that the jar tool man page changes should be separate from the changes to the test Otherwise it is OK test/jdk/tools/jar/ExtractFilesTest.java line 185: > 183: Assertions.assertTrue(baos.toString().contains(expected)); > 184: } > 185: Is this really needed vs just including the Assertions.assertTrue where you are replacing the existing Assertions.assertArrayEquals? I only ask as there is no additional validation in the method being added so outside of the change in methods. ------------- PR Review: https://git.openjdk.org/jdk/pull/21697#pullrequestreview-2395650507 PR Review Comment: https://git.openjdk.org/jdk/pull/21697#discussion_r1816916373
