On Fri, 25 Oct 2024 16:30:24 GMT, Henry Jen <henry...@openjdk.org> wrote:
> Valid points. > > A separate ticket is certainly better, or perhaps I should change the ticket > title. In a sense, I consider the man page change a missing part, Yes it could have been part of the original PR, but it is separate from fixing a test bug which is why IMHO it should be a separate PR and follow up work of the origin ticket, just like test failure. > > The extra method is so that we if we need to change the verification again. > The method could be better named as `verifyOutput` or else to reveal the > intention better. If you want to keep it as is, so be it, but on the flip side, it really is not adding value currently and could just be as easily added at the point in time if/when more validation is required. Again, just a passing observation for consideration. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21697#discussion_r1817025896
