On Fri, 1 Nov 2024 01:26:44 GMT, Mandy Chung <mch...@openjdk.org> wrote:
> I expect that the jmodless tests will first build an image (say `image1`) > using jlink `--generate-linkable-runtime` option and then verify > `image1/bin/jlink` that links from the run-time image. I don't see > `--generate-linkable-runtime` option is used from jmodless tests. I looked at > `AbstractLinkableRuntimeTest` which provides the support to create linkable > runtime image but not obvious to me. Can you describe the idea of this test > framework? OK. I see this now (`@requires jlink.runtime.linkable` in all jmodless tests). I.e. No test for the default JDK build. I think this feature needs test verification even for the default JDK build. One way to do that is to build a test image (say `base-image`) using jlink `--generate-linkable-runtime` option and then verify `base-image/bin/jlink` instead of the JDK. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-2452337769
