On Fri, 20 Dec 2024 22:20:16 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Henry Jen has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 16 additional commits >> since the last revision: >> >> - Merge remote-tracking branch 'openjdk/master' into JDK-8321413 >> - Javadoc and some minor refactoring >> - Move up Snippet setup as a builder >> - Merge remote-tracking branch 'openjdk/master' into JDK-8321413 >> - Minor cleanup >> - Rename based on feedback to emphasis building a snippet for loading a >> reference >> - Fix typo and comment to match latest implementation >> - Fix regression failed to setup helper methods properly >> - Separate out ModuleDescriptorBuilder and use LoadableArray for paging >> - Merge remote-tracking branch 'openjdk/master' into JDK-8321413 >> - ... and 6 more: https://git.openjdk.org/jdk/compare/69698dbb...d5a93295 > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > line 1216: > >> 1214: // and is load from the cache array with >> 1215: // dedupSetValues[index] >> 1216: // Otherwise, LoadableSet will load the set onto the >> operand stack. > > This comment needs update. No more `LoadableSet` RefCountSet sounds like a set, instead of a ref count. The implementation does hold the sorted elements in a list, but it's still not implementing java.util.Set so I am a little resist the call that a set. Would a RefCountProxy works? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21022#discussion_r1894493888
