On Fri, 20 Dec 2024 23:23:55 GMT, Henry Jen <henry...@openjdk.org> wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java >> line 1216: >> >>> 1214: // and is load from the cache array with >>> 1215: // dedupSetValues[index] >>> 1216: // Otherwise, LoadableSet will load the set onto the >>> operand stack. >> >> This comment needs update. No more `LoadableSet` > > RefCountSet sounds like a set, instead of a ref count. The implementation > does hold the sorted elements in a list, but it's still not implementing > java.util.Set so I am a little resist the call that a set. Would a > RefCountProxy works? Maybe simply `RefCounter`. It's okay for the implementation to hold a sorted list. The `elements` method can be renamed to `sortedList` that returns a List of elements sorted in ascending order. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21022#discussion_r1894528176
