On Wed, 12 Feb 2025 14:09:49 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this change in > `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the > `Deflater` instance cleanly? This addresses > https://bugs.openjdk.org/browse/JDK-8349907. > > As noted in that issue, the `Deflater` instance wasn't being closed in the > exception code path of this method. The commit in this PR merely changes the > code to use a try-with-resources block on the `Deflater` instance. > > No new tests have been introduced given the nature of the change. I've added > a `noreg-hard` to the issue. Existing tier1, tier2 and tier3 tests continue > to pass with this change without any related failures. Lance suggested including the `ByteArrayOutputStream` in the try-with-resources too to make the code more concise and cleaner. I have now updated the PR to follow that suggestion. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23588#issuecomment-2654099202
