> Can I please get a review of this change in > `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the > `Deflater` instance cleanly? This addresses > https://bugs.openjdk.org/browse/JDK-8349907. > > As noted in that issue, the `Deflater` instance wasn't being closed in the > exception code path of this method. The commit in this PR merely changes the > code to use a try-with-resources block on the `Deflater` instance. > > No new tests have been introduced given the nature of the change. I've added > a `noreg-hard` to the issue. Existing tier1, tier2 and tier3 tests continue > to pass with this change without any related failures.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision: Lance's suggestion ------------- Changes: - all: https://git.openjdk.org/jdk/pull/23588/files - new: https://git.openjdk.org/jdk/pull/23588/files/411f0375..3437f9ba Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=23588&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23588&range=00-01 Stats: 13 lines in 1 file changed: 4 ins; 7 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/23588.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23588/head:pull/23588 PR: https://git.openjdk.org/jdk/pull/23588
