On Tue, 25 Feb 2025 14:37:49 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Standardize parameter checking
>
> src/java.base/share/classes/java/util/concurrent/DelayScheduler.java line 99:
>
>> 97: * is typical with IO-based timeouts). The use of a 4-ary heap (in
>> 98: * which each element has up to 4 children) improves locality and
>> 99: * reduces movement and memory writes compared to a standard
>
> Suggestion:
>
> * which each element has up to 4 children) improves locality,
> * reduces movement, and memory writes compared to a standard
Now:
* which each element has up to 4 children) improves locality, and
* reduces the need for array movement and memory writes compared
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r1970465266
