On Tue, 25 Feb 2025 17:23:07 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Standardize parameter checking > > test/jdk/java/util/concurrent/tck/ForkJoinPool20Test.java line 649: > >> 647: p.shutdown(); >> 648: assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS)); >> 649: assertTrue(f.isDone()); > > Might make sense to factor out assertions of sets of states associated with > successful, cancelled, failed and use those asserts throughout these tests > (just to make sure that there aren't weird combinations of states). Right. We have some helper methods along these lines, but in the wrong test files (mainly ForkJoinTaskTest), so would need some refactoring to use here. Someday. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r1970630652
