On Wed, 26 Feb 2025 19:48:10 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which prevents an `AIOOBE` from leaking out when >> `java.util.Calendar.Builder` is used to build a Japanese calendar with an >> era value too large. >> >> Note that we don't check under `BEFORE_MEIJI`/0 as historically Japanese >> calendar ignores negative values during normalization. See >> `JapaneseImperialCalendar` L2018: `date.setEra(era > 0 ? eras[era] : >> null);`. >> >> We also check against `eras.length` over `REIWA`/5 due to the possibility of >> additional eras via the property override or future eras in general. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > Replace 7 w/ more meaningful value Thanks. I reviewed the CSR as well. ------------- Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23789#pullrequestreview-2645746475
